Update useFormState.test.js #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated 'Validation can handle validationOption changes' test so that they assume initial values are empty. This shows up a bug. The problem being that if you change then `validationOptions` data all the form state gets reset back to the initialValues. I then went through all the other tests here to see if this assumption caused any other bugs - but didn't find any. However I think it improves the tests assuming that the initial values will be empty - unless you are specifically testing initial values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated 'Validation can handle validationOption changes' test so that they assume initial values are empty. This shows up a bug. The problem being that if you change then
validationOptionsdata all the form state gets reset back to the initialValues.I then went through all the other tests here to see if this assumption caused any other bugs - but didn't find any. However I think it improves the tests assuming that the initial values will be empty - unless you are specifically testing initial values.
Note - this PR should leave the tests broken. I was going to leave it up to you to decide how best to fix it.